[GRADLE-3287] [JDK9] ClassCastException from org.gradle.process.internal.child.BootstrapSecurityManager Created: 19/Apr/15  Updated: 25/Jan/16  Resolved: 25/Jan/16

Status: Resolved
Project: Gradle
Affects Version/s: None
Fix Version/s: 2.12-rc-1

Type: Bug
Reporter: Sterling Greene Assignee: Unassigned
Resolution: Fixed Votes: 0



We are planning to change the application class loader not to be a URLClassLoader. org.gradle.process.internal.child.BootstrapSecurityManager depends on the internal implementation of the application class loader and will be broken in JDK 9.

Comment by Mandy Chung [ 02/Jul/15 ]

Due to this bug, it is not possible to run Gradle internally for some component testings using our prototype of replacing the application class loader with a non-URLClassLoader.

Is it possible to implement a simple workaround to check if the application class loader is an instance of URLClassLoader before the cast in Gradle 2.5 release?

It was pointed out that the reason why Gradle appends new paths to the classpath of the application class loader to workaround the windows ocmmand-line length limitation.

@argfile support is added in JDK 9 b80 that can be used to replace the current workaround:

Comment by David Hill [ 09/Nov/15 ]

JDK9 has added a new feature that could be used to solve this issue.

As I understand it, this feature of using the BootstrapSecurityManager was designed to work around the length of classpath arguments which can be very, very long with a complex process or a deep filesystem.

But JDK9 finally introduced @argfiles to the java command (something available to javac since JDK7).


In ./subprojects/core/src/main/groovy/org/gradle/process/internal/child/ApplicationClassesInSystemClassLoaderWorkerFactory.java

As a togglable option, instead of creating the subprocess with:
and serializing the classpath and alternate security manager, Write the classpath to a temporary file
in the form of:
Some notes on this format. Anything in quotes is white space compressed. I use this feature to indent my path elements, but this is not really needed. The \ at the end is a continuation as would be expected.

With the classpath written to a temp file (for example classpath.txt), invocation becomes:
java @classpath.txt [the rest of the arguments]
If an alternate security manager is requested, then that would be pasted on the command line too. Note that the whole command argument to java could be stuffed into the @argfile, so it really becomes a question of style and taste. Sometimes I prefer to make it -classpath @classpath.txt, leaving the text file to be only the classpath arguments - it might be a little bit clearer for debugging instead of just @classpath.txt

Then of course, don't serialize the classpath and security manager.

I think that there would not need to be any changes to GradleWorkerMain

BTW - using @argfile could certainly be toggled automatically if the running Java is >= JDK9, but it would be nice to have a user level toggle to force the issue. My team needs to build with JDK8 for a number of reasons - but would like to be able to use JDK9 for our JUnit testing, and so I want to be able to specify the test executable:

{ executable (jdk9_home + "/bin/java") }

Two minor issues holding me up with trying this and giving you a patch. I requested the process be started on getting approval for the Contributors Agreement, but that might take quite a while given the process (and lawyers) in a large corporation. The last issue is understanding how to expose the toggle to user level gradle.

Generated at Wed Jun 30 12:44:52 CDT 2021 using Jira 8.4.2#804003-sha1:d21414fc212e3af190e92c2d2ac41299b89402cf.