[GRADLE-3088] Up to date check not working when task contains object with equals method checking for class equality Created: 14/May/14  Updated: 10/Feb/17  Resolved: 10/Feb/17

Status: Resolved
Project: Gradle
Affects Version/s: None
Fix Version/s: None

Type: Bug
Reporter: Gradle Forums Assignee: Unassigned
Resolution: Won't Fix Votes: 0

Issue Links:
Related
Related to GRADLE-3018 The same enum values as task inputs a... Resolved

 Description   

If I execute the following task repeatedly it will always be executed because the up to data check fails and reports that the instance property changed.:

task gradlebug(type: Gradlebug) {
outDir file('bug')
}

class Gradlebug extends ConventionTask {
@Input
@Optional
SomeClass instance = new SomeClass();

@OutputDirectory
File outDir

@TaskAction
void doSomething() {
println "done"
}
}

class SomeClass implements Serializable {

boolean equals(Object o) {
println getClass().getClassLoader()
println o.getClass().getClassLoader()
return getClass() == o.getClass();
}
}

The problem did not exist with 1.10, but exists in 1.11 and 1.12. For 1.10 the `ClassLoader`s of `SomeClass` are the same instance, starting with 1.11 they are different instances which causes the `getClass() == o.getClass()` check to return false.

 Comments   
Comment by Benjamin Muschko [ 15/Nov/16 ]

As announced on the Gradle blog we are planning to completely migrate issues from JIRA to GitHub.

We intend to prioritize issues that are actionable and impactful while working more closely with the community. Many of our JIRA issues are inactionable or irrelevant. We would like to request your help to ensure we can appropriately prioritize JIRA issues you’ve contributed to.

Please confirm that you still advocate for your JIRA issue before December 10th, 2016 by:

  • Checking that your issues contain requisite context, impact, behaviors, and examples as described in our published guidelines.
  • Leave a comment on the JIRA issue or open a new GitHub issue confirming that the above is complete.

We look forward to collaborating with you more closely on GitHub. Thank you for your contribution to Gradle!

Comment by Benjamin Muschko [ 10/Feb/17 ]

Thanks again for reporting this issue. We haven't heard back from you after our inquiry from November 15th. We are closing this issue now. Please create an issue on GitHub if you still feel passionate about getting it resolved.

Generated at Wed Jun 30 12:39:37 CDT 2021 using Jira 8.4.2#804003-sha1:d21414fc212e3af190e92c2d2ac41299b89402cf.