[GRADLE-3084] CreateStartScripts in Application plugin escapes $ whether you want it to or not Created: 08/May/14  Updated: 10/Feb/17  Resolved: 10/Feb/17

Status: Resolved
Project: Gradle
Affects Version/s: None
Fix Version/s: None

Type: Bug
Reporter: Gradle Forums Assignee: Unassigned
Resolution: Won't Fix Votes: 2


 Description   

Traditionally, our application startup script has used a shell variable in the JVM options to supply an ID to our application. E.g.

-DappId=$appId

Recently, we switched to Gradle and began using the Appliation plugin to generate our startup scripts. However, the CreateStartScripts task is escaping every $ to \$. In our case, we don't want it to. It would be useful if the task had an option like "dontEscapeShellVariables" or something that could toggle this.



 Comments   
Comment by Gradle Forums [ 08/May/14 ]

Can you provide steps to reproduce please. There's a number of ways to supply JVM options that the application plugin's start scripts might be involved in so I'd like narrow it down.

Comment by Gradle Forums [ 08/May/14 ]

Sure, we just have this in our application's build.gradle

startScripts {
defaultJvmOpts = ['-DinstanceId=$instanceId']
}

Comment by Gradle Forums [ 08/May/14 ]

Oh, and we create the scripts themselves by running the distTar task, although the same scripts are generated when you run the install distZip and install tasks.

Comment by Nils Magnus Larsgård [ 18/Sep/14 ]

This applies to the 'applicationDefaultJvmArgs'-argument to the application-plugin as well.

applicationDefaultJvmArgs = ['-Ddw.server.applicationConnectors[0].port=$PORT']

renders this result in the generated shell-script:

DEFAULT_JVM_OPTS='"-Ddw.server.applicationConnectors[0].port=\$PORT"'

Comment by John Scancella [ 16/Mar/15 ]

I created a pull request that should solve this problem for the application plugin
https://github.com/gradle/gradle/pull/422

Comment by Ivan Balashov [ 24/Jul/15 ]

Any known workarounds? Run some post processing? Replace dollar sign with unicode sequence, maybe?

Comment by John Scancella [ 24/Jul/15 ]

@Ivan What I do to work around this is

startScripts{
   doLast{
     unixScript.text = unixScript.text.replace('\\', '')
}
Comment by Benjamin Muschko [ 15/Nov/16 ]

As announced on the Gradle blog we are planning to completely migrate issues from JIRA to GitHub.

We intend to prioritize issues that are actionable and impactful while working more closely with the community. Many of our JIRA issues are inactionable or irrelevant. We would like to request your help to ensure we can appropriately prioritize JIRA issues you’ve contributed to.

Please confirm that you still advocate for your JIRA issue before December 10th, 2016 by:

  • Checking that your issues contain requisite context, impact, behaviors, and examples as described in our published guidelines.
  • Leave a comment on the JIRA issue or open a new GitHub issue confirming that the above is complete.

We look forward to collaborating with you more closely on GitHub. Thank you for your contribution to Gradle!

Comment by Benjamin Muschko [ 10/Feb/17 ]

Thanks again for reporting this issue. We haven't heard back from you after our inquiry from November 15th. We are closing this issue now. Please create an issue on GitHub if you still feel passionate about getting it resolved.

Generated at Wed Jun 30 12:39:29 CDT 2021 using Jira 8.4.2#804003-sha1:d21414fc212e3af190e92c2d2ac41299b89402cf.