[GRADLE-2992] Application plugin should reduce risk of producing a script that exceeds Windows command length limit Created: 20/Jan/14  Updated: 10/Feb/17  Resolved: 10/Feb/17

Status: Resolved
Project: Gradle
Affects Version/s: None
Fix Version/s: None

Type: Bug
Reporter: Gradle Forums Assignee: Unassigned
Resolution: Won't Fix Votes: 12


 Description   

The script could additively build the classpath and not explicitly pass a -cp argument to `java`, instead relying on it picking up the CLASSPATH var.

As pointed out in the linked post, there are limits on environment variable length so there is still a boundary there.



 Comments   
Comment by Jesse Eichar [ 31/Mar/14 ]

If the java to be used is going to be Java 6 or higher the class path can be:

set CLASSPATH=%APP_HOME%/lib/*

See http://docs.oracle.com/javase/6/docs/technotes/tools/windows/classpath.html

look at the section on wildcards.

The targetCompatibility and sourceCompatibility can be used to see if the Java is Java 6+

My 2 cents

Comment by Mike M. [ 23/Apr/15 ]

I think a pathing jar would be a good and flexible solution that works on any jdk: See http://stackoverflow.com/a/201969/737587

Comment by Mike M. [ 23/Apr/15 ]

I wrote a workaround. It generates such a pathing jar and applies it in the windows cmd file:

// Fix command-length issue in windows startscript
task pathingJar(type: Jar) {
    appendix = 'pathing'
    manifest { attributes("Class-Path": configurations.runtime.collect { it.getName() }.join(' ') + ' ' + jar.archiveName ) }
}
applicationDistribution.from(pathingJar) { into "lib" }
startScripts {
    doLast {
        def winScriptFile  = file getWindowsScript()
        def winFileText = winScriptFile.text

        // Remove too-long-classpath and use pathing jar instead
        winFileText = winFileText.replaceAll('set CLASSPATH=.*', 'rem CLASSPATH declaration removed.')
        winFileText = winFileText.replaceAll('("%JAVA_EXE%" .* -classpath ")%CLASSPATH%(" .*)', '$1%APP_HOME%\\\\lib\\\\' + pathingJar.archiveName + '$2')

        winScriptFile.text = winFileText
    }
}
Comment by Amit [ 03/Sep/15 ]

My workaround solution for this ,( works for java 6 and above only)

startScripts
{
doLast

{ // Remove too-long-classpath and use wildcard ( works for java 6 and above only) windowsScript.text = windowsScript.text.replaceAll('set CLASSPATH=.*', 'set CLASSPATH=.;%APP_HOME%/lib/*') }

}

Comment by Michel Krämer [ 22/Jan/16 ]

> I wrote a workaround. It generates such a pathing jar and applies it in the windows cmd file:

+1

Comment by David Burns [ 27/Feb/16 ]

Also +1 for the pathing jar solution - if order of jars is not important, then the wildcard is probably fine. For me order was important and so wildcard solution gave different results.

Comment by Benjamin Muschko [ 15/Nov/16 ]

As announced on the Gradle blog we are planning to completely migrate issues from JIRA to GitHub.

We intend to prioritize issues that are actionable and impactful while working more closely with the community. Many of our JIRA issues are inactionable or irrelevant. We would like to request your help to ensure we can appropriately prioritize JIRA issues you’ve contributed to.

Please confirm that you still advocate for your JIRA issue before December 10th, 2016 by:

  • Checking that your issues contain requisite context, impact, behaviors, and examples as described in our published guidelines.
  • Leave a comment on the JIRA issue or open a new GitHub issue confirming that the above is complete.

We look forward to collaborating with you more closely on GitHub. Thank you for your contribution to Gradle!

Comment by Benjamin Muschko [ 10/Feb/17 ]

Thanks again for reporting this issue. We haven't heard back from you after our inquiry from November 15th. We are closing this issue now. Please create an issue on GitHub if you still feel passionate about getting it resolved.

Generated at Wed Jun 30 12:36:57 CDT 2021 using Jira 8.4.2#804003-sha1:d21414fc212e3af190e92c2d2ac41299b89402cf.