[GRADLE-270] Make the closure parameter of the fileSet method of the archive tasks optional Created: 22/Oct/08  Updated: 04/Jan/13  Resolved: 30/Oct/08

Status: Resolved
Project: Gradle
Affects Version/s: None
Fix Version/s: 0.5

Type: Improvement
Reporter: Martin Vlcek Assignee: Hans Dockter
Resolution: Cannot Reproduce Votes: 0


In manually created archive tasks - e.g. createTask(type: Jar) - the fileSet method requires a second parameter (a closure) besides the "dir" parameter.
This parameter should be optional, as

  • it is not always needed
  • the syntax should be the same as for the fileSet() method of the jar() method of the dists task, which does not need the closure.

This applies to all archive tasks.

Comment by Hans Dockter [ 30/Oct/08 ]

I can't reproduce this. As far as I can tell the closure is optional.

This is the signature of the relevant method: FileSet fileSet(Map args = [:], Closure configureClosure = null)

Comment by Hans Dockter [ 30/Oct/08 ]

I'm closing this issue. If there has been a misunderstanding on my side, please reopen it.

Comment by Martin Vlcek [ 31/Oct/08 ]

OK, just tried again and it works. I probably forgot the .configure when trying it first

Generated at Wed Jun 30 11:25:55 CDT 2021 using Jira 8.4.2#804003-sha1:d21414fc212e3af190e92c2d2ac41299b89402cf.