[GRADLE-2405] Tooling API should respect -Dgradle.user.home Created: 29/Jul/12  Updated: 10/Feb/17  Resolved: 10/Feb/17

Status: Resolved
Project: Gradle
Affects Version/s: 1.1-rc-2
Fix Version/s: None

Type: Bug
Reporter: Luke Daley Assignee: Radim Kubacki
Resolution: Won't Fix Votes: 0


 Description   

https://github.com/gradle/gradle/blob/master/subprojects/tooling-api/src/main/java/org/gradle/tooling/internal/consumer/ConnectorServices.java#L37

This should use the 'gradle.user.home' if it's set.



 Comments   
Comment by Radim Kubacki [ 03/Feb/14 ]

We could have it but Adam expressed his opinion in the review that only http://www.gradle.org/docs/current/javadoc/org/gradle/tooling/GradleConnector.html#useGradleUserHomeDir(java.io.File) should be used. This way it is simpler to deduce what will be used by tooling API client. OTOH it shift the responsibility of handling gradle.user.home system property of GRADLE_USER_HOME env var to client code. Do we want to close this now?

If we change out mind we can revert https://github.com/gradle/gradle/commit/3a8ca3e97f94646399c154b7a9efcb3e340e97b7

Comment by Adam Murdoch [ 05/Feb/14 ]

Let's leave this issue open. My objection was to making these magic properties part of the cross-version API by implementing the handling in tooling API consumer. We can honour the magic properties, but we need to implement it in version-spectific way, by having the provider version involved in some way.

Comment by Benjamin Muschko [ 15/Nov/16 ]

As announced on the Gradle blog we are planning to completely migrate issues from JIRA to GitHub.

We intend to prioritize issues that are actionable and impactful while working more closely with the community. Many of our JIRA issues are inactionable or irrelevant. We would like to request your help to ensure we can appropriately prioritize JIRA issues you’ve contributed to.

Please confirm that you still advocate for your JIRA issue before December 10th, 2016 by:

  • Checking that your issues contain requisite context, impact, behaviors, and examples as described in our published guidelines.
  • Leave a comment on the JIRA issue or open a new GitHub issue confirming that the above is complete.

We look forward to collaborating with you more closely on GitHub. Thank you for your contribution to Gradle!

Comment by Benjamin Muschko [ 10/Feb/17 ]

Thanks again for reporting this issue. We haven't heard back from you after our inquiry from November 15th. We are closing this issue now. Please create an issue on GitHub if you still feel passionate about getting it resolved.

Generated at Wed Jun 30 12:21:01 CDT 2021 using Jira 8.4.2#804003-sha1:d21414fc212e3af190e92c2d2ac41299b89402cf.