[GRADLE-2306] It would be really nice if boolean properties set in gradle.properties were casted by Gradle to booleans Created: 16/May/12  Updated: 10/Feb/17  Resolved: 10/Feb/17

Status: Resolved
Project: Gradle
Affects Version/s: 1.0-rc-3
Fix Version/s: None

Type: New Feature
Reporter: Mauro Molinari Assignee: Unassigned
Resolution: Won't Fix Votes: 7


 Description   

I know this wish may sound debatable, but there's something I find really uncomfortable with Gradle right now.

Suppose you have:

master/gradle.properties
myProp=false

and:

master/settings.gradle
includeFlat 'subprj'

and:

master/build.gradle
if(myProp)
  println "master: true"
else
  println "master: false

and:

subprj/build.gradle
if(myProp)
  println "subprj: true"
else
  println "subprj: false

If I run the script, the following is output:

master: true
subprj: true

This is because myProp is set on both master and subprj as a string property and a string property always evaluates to boolean true when the string is not null and not empty.
Under the point of view of the "least surprise", this is already something that the user will discover by banging his nose against the wall (I'm also wondering why Groovy is not "smart enough" to consider "false" as boolean false...). But it's even more annoying if you consider that changing master/build.gradle in the following way:

master/build.gradle
myProp = myProp.toBoolean()
if(myProp)
  println "master: true"
else
  println "master: false

isn't enough yet, because myProp is independently set on all the projects (and not only on the root one) and hence the output will now be:

master: false
subprj: true

So, you eventually have to do:

master/build.gradle
allprojects { myProp = myProp.toBoolean() }
if(myProp)
  println "master: true"
else
  println "master: false

which is overwhelming, IMHO, unless you remember to put "toBoolean()" method call in all of your "if" statements instead.

So, what do you think about the idea to make Gradle "detect" boolean properties in gradle.properties and automatically cast them to booleans before setting them on the projects?
This might be extended to integers and floats/doubles, for instance, but I think this might be less vital, since it's less likely that trying to use strings instead of numbers will affect users in unexpected (and sometimes hard to debug) ways.



 Comments   
Comment by Benjamin Muschko [ 15/Nov/16 ]

As announced on the Gradle blog we are planning to completely migrate issues from JIRA to GitHub.

We intend to prioritize issues that are actionable and impactful while working more closely with the community. Many of our JIRA issues are inactionable or irrelevant. We would like to request your help to ensure we can appropriately prioritize JIRA issues you’ve contributed to.

Please confirm that you still advocate for your JIRA issue before December 10th, 2016 by:

  • Checking that your issues contain requisite context, impact, behaviors, and examples as described in our published guidelines.
  • Leave a comment on the JIRA issue or open a new GitHub issue confirming that the above is complete.

We look forward to collaborating with you more closely on GitHub. Thank you for your contribution to Gradle!

Comment by Benjamin Muschko [ 10/Feb/17 ]

Thanks again for reporting this issue. We haven't heard back from you after our inquiry from November 15th. We are closing this issue now. Please create an issue on GitHub if you still feel passionate about getting it resolved.

Generated at Wed Jun 30 12:18:21 CDT 2021 using Jira 8.4.2#804003-sha1:d21414fc212e3af190e92c2d2ac41299b89402cf.