[GRADLE-2243] findbugs plugin ignores "ignoreFailures" properties Created: 19/Apr/12  Updated: 04/Jan/13  Resolved: 19/Apr/12

Status: Resolved
Project: Gradle
Affects Version/s: 1.0-rc-1
Fix Version/s: 1.1-rc-1

Type: Bug
Reporter: Gradle Forums Assignee: René Gröschke (Inactive)
Resolution: Fixed Votes: 0

Issue Links:
Duplicate
Duplicates GRADLE-2227 upgrade form m9 to rc1 findbugs plugi... Resolved

 Description   

I migrated from milestone-8 to rc-1 and now my build breaks because the findbugs plugin ignores the setting of the ignoreFailure property (we have some timing tests and running with cobertura is much slower than plain junit).

After quite some fiddling with the source of the plugin, it appears this is due to line 119 in FindBugs.groovy:
if (findbugsResult.bugCount && !ignoreFailures) {
it should be
if (findbugsResult.bugCount && !getIgnoreFailures()) {

I'm not an expert on gradle, but it appears this property is now part of a convention object which requires different access than before???

 Comments   
Comment by Gradle Forums [ 19/Apr/12 ]

Hello geert,
thanks for the report. I'll fix this immediately. for the mean time you can use the following workaround to set the ignoreFailures property for all your findbugs tasks:

tasks.withType(FindBugs){
ignoreFailures = true
}

Comment by Gradle Forums [ 19/Apr/12 ]

Thanks for the quick workaround.

Comment by Jarod Liu [ 19/Apr/12 ]

my patch for this issue https://github.com/gradle/gradle/pull/80

Comment by Justin Ryan [ 19/Apr/12 ]

It probably creeped in because of GRADLE-2163, where booleans weren't working in conventions, and someone tried working around it.

Comment by Karl-Johan Karlberg [ 28/Jun/12 ]

Is it fixed or not I'm using gradle 1.0 and have the problem that findbugs does not honor the value I set like:
findbugs.ignoreFailures = true

It works find with the workaround though...

Generated at Wed Jun 30 12:16:36 CDT 2021 using Jira 8.4.2#804003-sha1:d21414fc212e3af190e92c2d2ac41299b89402cf.