[GRADLE-1634] AbstractTask#execute() should be final. Created: 23/Jun/11 Updated: 04/Jan/13 Resolved: 14/Jul/11 |
|
| Status: | Resolved |
| Project: | Gradle |
| Affects Version/s: | None |
| Fix Version/s: | 1.0-milestone-4 |
| Type: | Improvement | ||
| Reporter: | Luke Daley | Assignee: | Luke Daley |
| Resolution: | Fixed | Votes: | 0 |
| Description |
|
There is a strong tendency to unintentionally override this method when developing a custom task. Doing this will silently bypass up-to-date and onlyIf checks etc. After discussion, Adam advocated just making the method final. |
| Comments |
| Comment by Luke Daley [ 14/Jul/11 ] |
|
By: https://github.com/gradle/gradle/commit/cc962e4c91751d650c0d680067276d85448cc487 |