Uploaded image for project: 'Gradle'
  1. Gradle
  2. GRADLE-1372

Make the wrapper a build-in task

    Details

    • Type: Improvement
    • Status: Resolved
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.7-rc-1

      Description

      What about making the wrapper a build-in task? It does not make much sense to configure it in the build script anyhow. The proposed way to maintain the wrapper configuration is via the properties file. I find it awkward and confusing at the moment, that initially you are supposed to configure in the build script and afterwards in the properties file.

      So why not just make it build-in. Every property is generated with a default value. For customization and maintenance you just edit the properties file.

        Activity

        Hide
        nathan.neff Nathan Neff added a comment -

        Hello,

        Jeff and I have a potential solution for this issue.
        I will be submitting a pull request today (03/28/2011) or
        tomorrow.

        Thanks,
        --Nate

        Show
        nathan.neff Nathan Neff added a comment - Hello, Jeff and I have a potential solution for this issue. I will be submitting a pull request today (03/28/2011) or tomorrow. Thanks, --Nate
        Hide
        nathan.neff Nathan Neff added a comment -

        I also think that command-line switches would be nice when
        calling "gradle wrapper", instead of editing the properties file.

        For example, I have open-source project, and want to make it easy to run
        gradle tasks, but I have a different distributionUrl. I could just say:

        >gradle wrapper --distributionUrl=http://example.com/mygradle.zip

        Show
        nathan.neff Nathan Neff added a comment - I also think that command-line switches would be nice when calling "gradle wrapper", instead of editing the properties file. For example, I have open-source project, and want to make it easy to run gradle tasks, but I have a different distributionUrl. I could just say: >gradle wrapper --distributionUrl= http://example.com/mygradle.zip
        Hide
        szczepiq Szczepan Faber added a comment -

        >What about making the wrapper a build-in task?

        +1. It feels a bit weird to first change the version in script, then run the build. Much more natural would be to simply change the properties file and that's it. It is also a bit confusing that you can have version X in wrapper task in build.gradle but version Y in gradle-wrapper.properties.

        Show
        szczepiq Szczepan Faber added a comment - >What about making the wrapper a build-in task? +1. It feels a bit weird to first change the version in script, then run the build. Much more natural would be to simply change the properties file and that's it. It is also a bit confusing that you can have version X in wrapper task in build.gradle but version Y in gradle-wrapper.properties.

          People

          • Assignee:
            Unassigned
            Reporter:
            hans_d Hans Dockter
          • Votes:
            4 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development