[GRADLE-1350] More user-friendly behavior for the case where convention property is set before plugin has been applied Created: 25/Jan/11  Updated: 10/Feb/17  Resolved: 10/Feb/17

Status: Resolved
Project: Gradle
Affects Version/s: 0.9.2
Fix Version/s: None

Type: Improvement
Reporter: Peter Niederwieser Assignee: Unassigned
Resolution: Won't Fix Votes: 6

Attachments: Text File patch-ClassCastException.txt    
Issue Links:
Supercedes
Supercedes GRADLE-1329 sourceCompatibility = 1.6 broken for ... Resolved

 Description   

If a convention property is set before the corresponding plugin has been applied, strange errors may occur (see linked issue). We should try to either support this scenario or provide a clear error message.



 Comments   
Comment by Peter Niederwieser [ 16/Feb/11 ]

Situations where this happens:

  • Convention property set at top of script, before plugin has been applied (easy to work around)
  • Convention property defined in gradle.properties
  • Convention property passed from the command-line with -P
Comment by Arnaud Nauwynck [ 15/Jan/13 ]

I was interested in a fix of GRADDLE-1666 but this issue was marked as a duplicate of this one

... I encounter ClassCastExceptions in gradle-eclipse plugin, but I don't want to change the project under build (downloaded, with complex layout and tasks)

Caused by: java.lang.ClassCastException: java.math.BigDecimal cannot be cast to org.gradle.api.JavaVersion
at org.gradle.plugins.ide.eclipse.model.EclipseJdt_Decorated.getTargetCompatibility(Unknown Source)
at org.gradle.api.internal.BeanDynamicObject$MetaClassAdapter.getProperty(BeanDynamicObject.java:146)
at org.gradle.api.internal.BeanDynamicObject.getProperty(BeanDynamicObject.java:102)
at org.gradle.api.internal.CompositeDynamicObject.getProperty(CompositeDynamicObject.java:78)
at org.gradle.plugins.ide.eclipse.model.EclipseJdt_Decorated.getProperty(Unknown Source)
at org.gradle.plugins.ide.eclipse.GenerateEclipseJdt.configure(GenerateEclipseJdt.groovy:53)
at org.gradle.plugins.ide.eclipse.GenerateEclipseJdt.configure(GenerateEclipseJdt.groovy)
at org.gradle.plugins.ide.api.PropertiesGeneratorTask$1.configure(PropertiesGeneratorTask.java:37)
at org.gradle.plugins.ide.api.PropertiesGeneratorTask$1.configure(PropertiesGeneratorTask.java:31)
at org.gradle.plugins.ide.api.GeneratorTask.generate(GeneratorTask.java:75)
at org.gradle.api.internal.BeanDynamicObject$MetaClassAdapter.invokeMethod(BeanDynamicObject.java:216)
at org.gradle.api.internal.BeanDynamicObject.invokeMethod(BeanDynamicObject.java:122)
at org.gradle.api.internal.CompositeDynamicObject.invokeMethod(CompositeDynamicObject.java:147)
at org.gradle.plugins.ide.eclipse.GenerateEclipseJdt_Decorated.invokeMethod(Unknown Source)

However, I have noticed few things...

1) using in the project the verbose syntax "sourceCompatibility = JavaVersion.VERSION_1_6" can work (instead of "sourceCompatibility = 1.6")

2) there is a mismatch between field type and setter/getter type due to BeanDynamicObject _Generated class.
The following workaround works on gradle-eclipse plugin: changed type to "object", which is consistent with setter type... then called additional converter after getter for ensuring conversion / compile-type-check to type "JavaVersion"
Here is a git patch to apply

index b6f81f1..45b6e0e 100644
— a/subprojects/ide/src/main/groovy/org/gradle/plugins/ide/eclipse/model/EclipseJdt.groovy
+++ b/subprojects/ide/src/main/groovy/org/gradle/plugins/ide/eclipse/model/EclipseJdt.groovy
@@ -63,7 +63,8 @@ class EclipseJdt {

  • <p>
  • For example see docs for {@link EclipseJdt}
    */
    - JavaVersion sourceCompatibility
    +// JavaVersion sourceCompatibility
    + def sourceCompatibility

    void setSourceCompatibility(Object sourceCompatibility) {
    this.sourceCompatibility = JavaVersion.toVersion(sourceCompatibility)
    @@ -74,7 +75,8 @@ class EclipseJdt {
    * <p>
    * For example see docs for {@link EclipseJdt}

    */

  • JavaVersion targetCompatibility
    +// JavaVersion targetCompatibility
    + def targetCompatibility

void setTargetCompatibility(Object targetCompatibility) {
this.targetCompatibility = JavaVersion.toVersion(targetCompatibility)

Comment by Adam Walczak - WALCZAK.IT [ 04/Aug/13 ]

personally I think the string representation of the version should be also accepted every where, its much cleaner to store this type of properties in the gradle.properties file

Comment by Benjamin Muschko [ 15/Nov/16 ]

As announced on the Gradle blog we are planning to completely migrate issues from JIRA to GitHub.

We intend to prioritize issues that are actionable and impactful while working more closely with the community. Many of our JIRA issues are inactionable or irrelevant. We would like to request your help to ensure we can appropriately prioritize JIRA issues you’ve contributed to.

Please confirm that you still advocate for your JIRA issue before December 10th, 2016 by:

  • Checking that your issues contain requisite context, impact, behaviors, and examples as described in our published guidelines.
  • Leave a comment on the JIRA issue or open a new GitHub issue confirming that the above is complete.

We look forward to collaborating with you more closely on GitHub. Thank you for your contribution to Gradle!

Comment by Benjamin Muschko [ 10/Feb/17 ]

Thanks again for reporting this issue. We haven't heard back from you after our inquiry from November 15th. We are closing this issue now. Please create an issue on GitHub if you still feel passionate about getting it resolved.

Generated at Wed Jun 30 11:53:19 CDT 2021 using Jira 8.4.2#804003-sha1:d21414fc212e3af190e92c2d2ac41299b89402cf.