[GRADLE-1742] Allow maximum number of CodeNarc violations to be configurable Created: 11/Aug/11 Updated: 19/May/13 Resolved: 03/May/13 |
|
| Status: | Resolved |
| Project: | Gradle |
| Affects Version/s: | 1.0-milestone-4 |
| Fix Version/s: | 1.7-rc-1 |
| Type: | Improvement | ||
| Reporter: | Levi Hoogenberg | Assignee: | René Gröschke (Inactive) |
| Resolution: | Fixed | Votes: | 1 |
| Description |
|
At the moment, a single CodeNarc violation causes the build to fail. It would be nice if this would be configurable (e.g. allow at most 0 priority 1 violations, 5 priority 2 ones, and 10 priority 3 ones). This would probably remove the need for the ignoreFailures setting as well. |
| Comments |
| Comment by Peter Niederwieser [ 12/Aug/11 ] |
|
You may want to have a look at http://evgeny-goldin.com/wiki/Gradle-CodeNarc-plugin, which claims to be a more flexible CodeNarc plugin. |
| Comment by Levi Hoogenberg [ 14/Aug/11 ] |
|
Thanks, Peter - this issue was created after a question on the mailing list. I posted a follow-up question on the mailing list as well. |
| Comment by Levi Hoogenberg [ 20/Aug/11 ] |
|
I merged the approach taken in Evgeny's and Gradle's plugins (into http://code.google.com/p/rivoli/source/browse/gradle/codenarc.gradle - it's somewhat ironic that we haven't configured the number of allowed violations yet) - you may close this issue as "won't fix" (unless someone else is interested in fixing it). |
| Comment by Dan Stine [ 26/Mar/13 ] |
|
I have submitted a pull request that addresses this issue. |
| Comment by René Gröschke (Inactive) [ 03/May/13 ] |
|
solved via pull-request. thanks Dan! |