Gradle

  • Log In Access more options
    • Online Help
    • Keyboard Shortcuts
    • About JIRA
    • JIRA Credits
    • What’s New
  • Dashboards Access more options (Alt+d)
  • Projects Access more options (Alt+p)
  • Issues Access more options (Alt+i)
To raise new issues or bugs against Gradle, please use forums.gradle.org.
  • Gradle
  • GRADLE-1634

AbstractTask#execute() should be final.

  • Log In
  • Views
    • XML
    • Word
    • Printable

Details

  • Type: Improvement Improvement
  • Status: Resolved Resolved
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 1.0-milestone-4

Description

There is a strong tendency to unintentionally override this method when developing a custom task. Doing this will silently bypass up-to-date and onlyIf checks etc.

After discussion, Adam advocated just making the method final.

Activity

  • All
  • Comments
  • History
  • Activity
  • TeamCity
  • Commits
  • Source
  • Reviews
Hide
Permalink
Luke Daley added a comment - 14/Jul/11 2:38 AM

By: https://github.com/gradle/gradle/commit/cc962e4c91751d650c0d680067276d85448cc487

Show
Luke Daley added a comment - 14/Jul/11 2:38 AM By: https://github.com/gradle/gradle/commit/cc962e4c91751d650c0d680067276d85448cc487

People

  • Assignee:
    Luke Daley
    Reporter:
    Luke Daley
Vote (0)
Watch (0)

Dates

  • Created:
    23/Jun/11 3:25 AM
    Updated:
    04/Jan/13 5:10 AM
    Resolved:
    14/Jul/11 2:38 AM
  • Atlassian JIRA (v5.0.3#729-sha1:bf569e4)
  • Report a problem
  • Powered by a free Atlassian JIRA open source license for Gradle. Try JIRA - bug tracking software for your team.