[GRADLE-3340] Jar task is UP_TO_DATE altough manifest attribute was changed Created: 16/Sep/15 Updated: 28/Sep/15 Resolved: 28/Sep/15 |
|
| Status: | Resolved |
| Project: | Gradle |
| Affects Version/s: | None |
| Fix Version/s: | 2.8-rc-1 |
| Type: | Bug | ||
| Reporter: | Daz DeBoer | Assignee: | Lari Hotari |
| Resolution: | Fixed | Votes: | 0 |
| Known Issue Of: |
| Description |
|
https://discuss.gradle.org/t/jar-task-is-up-to-date-altough-manifest-attribute-was-changed/11636 |
| Comments |
| Comment by Lari Hotari [ 28/Sep/15 ] |
|
My change has broken this: https://github.com/gradle/gradle/commit/7bd1cfe2 The reason why I made this change was to fix the problem of the jar task triggering changes by modifying MANIFEST.MF each and every time. This was a problem with a test, https://github.com/gradle/gradle/blob/758e5b8703d16f03d64e425e6c66a4e121a74dca/subprojects/launcher/src/integTest/groovy/org/gradle/launcher/continuous/EnablingContinuousModeExecutionIntegrationTest.groovy#L316-L334 . That test was later on removed completely. Should we just revert 7bd1cfe2 and leave the problem of re-creating MANIFEST.MF each time? |
| Comment by Lari Hotari [ 28/Sep/15 ] |
|
Another reason for that change was that we first were tracking changes made during the build in continuous mode. The unnecessary MANIFEST.MF update would cause the build to execute in a loop. Since the continuous mode implementation is ignoring changes made during the build, it should be safe to revert https://github.com/gradle/gradle/commit/7bd1cfe2 . |
| Comment by Lari Hotari [ 28/Sep/15 ] |
|
reverted in release branch by https://github.com/gradle/gradle/commit/81c6d61d |