[GRADLE-2736] Add the filename to an compilation exception in the CoffeeScript plugin Created: 05/Apr/13  Updated: 10/Feb/17  Resolved: 10/Feb/17

Status: Resolved
Project: Gradle
Affects Version/s: None
Fix Version/s: None

Type: Bug
Reporter: Mehdi Houshmand Assignee: Unassigned
Resolution: Won't Fix Votes: 0


 Description   

The CoffeeScript compiler plugin doesn’t currently display the filename of the erring file when an exception is thrown by Rhino. The code change is fairly simple, line 61 of the CoffeeScript compiler worker[1] is currently:

return (String)context.evaluateString(compileScope, "CoffeeScript.compile(coffeeScriptSource, {});", sourceName, 0, null);

To add the file name the code should look like:

compileScope.put("sourceName", compileScope, source);
return (String)context.evaluateString(compileScope, "CoffeeScript.compile(coffeeScriptSource,

{ filename: sourceName }

);", sourceName, 0, null);

This allows the actual CoffeeScript compiler running in Rhino to have access to the name of the source file which already puts the file name in the error message. If you need the patch in a different form I’d be happy to upload a Git diff.

[1] https://github.com/gradle/gradle/blob/master/subprojects/javascript/src/main/groovy/org/gradle/plugins/javascript/coffeescript/compile/internal/rhino/CoffeeScriptCompilerWorker.java

 Comments   
Comment by Benjamin Muschko [ 15/Nov/16 ]

As announced on the Gradle blog we are planning to completely migrate issues from JIRA to GitHub.

We intend to prioritize issues that are actionable and impactful while working more closely with the community. Many of our JIRA issues are inactionable or irrelevant. We would like to request your help to ensure we can appropriately prioritize JIRA issues you’ve contributed to.

Please confirm that you still advocate for your JIRA issue before December 10th, 2016 by:

  • Checking that your issues contain requisite context, impact, behaviors, and examples as described in our published guidelines.
  • Leave a comment on the JIRA issue or open a new GitHub issue confirming that the above is complete.

We look forward to collaborating with you more closely on GitHub. Thank you for your contribution to Gradle!

Comment by Benjamin Muschko [ 10/Feb/17 ]

Thanks again for reporting this issue. We haven't heard back from you after our inquiry from November 15th. We are closing this issue now. Please create an issue on GitHub if you still feel passionate about getting it resolved.

Generated at Wed Jun 30 12:30:05 CDT 2021 using Jira 8.4.2#804003-sha1:d21414fc212e3af190e92c2d2ac41299b89402cf.