[GRADLE-2259] extra property and extension name clash is detected late Created: 30/Apr/12  Updated: 10/Feb/17  Resolved: 10/Feb/17

Status: Resolved
Project: Gradle
Affects Version/s: 1.0-milestone-9
Fix Version/s: None

Type: Bug
Reporter: Szczepan Faber Assignee: Unassigned
Resolution: Won't Fix Votes: 0


 Description   

Consider the following:

apply plugin: 'eclipse'
ext.eclipse = ['gradle': 'is awesome']

//no longer possible:
eclipse.project.name = 'my project'

Above is just an example, there are cases where creating extra property that matches existing extension name may lead to runtime failures.

At minimum we should fail fast if someone overrides existing extension with an extra property (IMHO)

 Comments   
Comment by Adam Murdoch [ 08/May/12 ]

We should deal with all kinds of collisions.

I think the order of precedence for resolving a property or method should be:

  • Built-in property or method
  • Task (or more generally, an element in the current container)
  • Extension
  • Convention object
  • Extra property

That is, extensions should win over extra properties.

As far as collision handling goes, we can either warn or fail when a collision is detected. Detection can happen either when the property is accessed, or when the task/extension/extra property is defined. If we do the detection at definition time, we have to deal with ordering to some degree, as an extra property can be defined before or after the extension that it collides with is defined.

We'd also need to deal with some of the intentional collisions we have, for example, where we have both an 'eclipse' task and an 'eclipse' extension for a given Project object.

Comment by Benjamin Muschko [ 15/Nov/16 ]

As announced on the Gradle blog we are planning to completely migrate issues from JIRA to GitHub.

We intend to prioritize issues that are actionable and impactful while working more closely with the community. Many of our JIRA issues are inactionable or irrelevant. We would like to request your help to ensure we can appropriately prioritize JIRA issues you’ve contributed to.

Please confirm that you still advocate for your JIRA issue before December 10th, 2016 by:

  • Checking that your issues contain requisite context, impact, behaviors, and examples as described in our published guidelines.
  • Leave a comment on the JIRA issue or open a new GitHub issue confirming that the above is complete.

We look forward to collaborating with you more closely on GitHub. Thank you for your contribution to Gradle!

Comment by Benjamin Muschko [ 10/Feb/17 ]

Thanks again for reporting this issue. We haven't heard back from you after our inquiry from November 15th. We are closing this issue now. Please create an issue on GitHub if you still feel passionate about getting it resolved.

Generated at Wed Jun 30 12:17:04 CDT 2021 using Jira 8.4.2#804003-sha1:d21414fc212e3af190e92c2d2ac41299b89402cf.