[GRADLE-2255] CopySpec.eachFile() not receiving empty directories from zipTree Created: 26/Apr/12  Updated: 10/Feb/17  Resolved: 10/Feb/17

Status: Resolved
Project: Gradle
Affects Version/s: 1.0-rc-1
Fix Version/s: None

Type: Bug
Reporter: Bob Glamm Assignee: Unassigned
Resolution: Won't Fix Votes: 5


 Description   

Extracting a Zip archive that includes empty directories fails to send empty directories to CopySpec.eachFile(). For example:

file.zip contains:

zipRootPath/
zipRootPath/file1.txt
zipRootPath/emptyDir/

copy {
from zipTree("file.zip")
eachFile

{ it.setPath(it.getPath().replaceFirst("^zipRootPath", "destRootPath")) }

into "targetDir"
}

The above inputs will result in this file/directory structure in targetDir:

targetDir/
targetDir/zipRootPath/
targetDir/zipRootPath/emptyDir/
targetDir/destRootPath/
targetDir/destRootPath/file1.txt

because "zipRootPath/emptyDir/" is never sent to the eachFile closure, above.

Current workaround:

copy

{ from zipTree("file.zip") into "targetDir" }

file("targetDir/zipRootPath").renameTo("targetDir/destRootPath")

The problem with the workaround is that multiple calls to copy

{ from zipTree() }

on a large ZIP file result in long ZIP extraction times (e.g. to extract different pieces of the ZIP file at different times, or to work around other Gradle ZIP extraction bugs).

Possible suggested solutions:

1) Modify the code that calls the eachFile closure to include directories
2) Add a call to a closure (eachEntry?) which receives all files and directories
3) Add a call to a closure that only receives directories

 Comments   
Comment by Szczepan Faber [ 30/Apr/12 ]

Hello,

eachFile() does not support directories at the moment and it is indeed a missing capability. I have a feeling we already have few issues that directly/indirectly depend on that.

Thanks for reporting!

Comment by Benjamin Muschko [ 15/Nov/16 ]

As announced on the Gradle blog we are planning to completely migrate issues from JIRA to GitHub.

We intend to prioritize issues that are actionable and impactful while working more closely with the community. Many of our JIRA issues are inactionable or irrelevant. We would like to request your help to ensure we can appropriately prioritize JIRA issues you’ve contributed to.

Please confirm that you still advocate for your JIRA issue before December 10th, 2016 by:

  • Checking that your issues contain requisite context, impact, behaviors, and examples as described in our published guidelines.
  • Leave a comment on the JIRA issue or open a new GitHub issue confirming that the above is complete.

We look forward to collaborating with you more closely on GitHub. Thank you for your contribution to Gradle!

Comment by Benjamin Muschko [ 10/Feb/17 ]

Thanks again for reporting this issue. We haven't heard back from you after our inquiry from November 15th. We are closing this issue now. Please create an issue on GitHub if you still feel passionate about getting it resolved.

Generated at Wed Jun 30 12:16:57 CDT 2021 using Jira 8.4.2#804003-sha1:d21414fc212e3af190e92c2d2ac41299b89402cf.