Uploaded image for project: 'Gradle'
  1. Gradle
  2. GRADLE-1742

Allow maximum number of CodeNarc violations to be configurable

    Details

    • Type: Improvement
    • Status: Resolved
    • Resolution: Fixed
    • Affects Version/s: 1.0-milestone-4
    • Fix Version/s: 1.7-rc-1

      Description

      At the moment, a single CodeNarc violation causes the build to fail. It would be nice if this would be configurable (e.g. allow at most 0 priority 1 violations, 5 priority 2 ones, and 10 priority 3 ones). This would probably remove the need for the ignoreFailures setting as well.

        Activity

        levi_h Levi Hoogenberg created issue -
        Hide
        pniederw Peter Niederwieser added a comment -

        You may want to have a look at http://evgeny-goldin.com/wiki/Gradle-CodeNarc-plugin, which claims to be a more flexible CodeNarc plugin.

        Show
        pniederw Peter Niederwieser added a comment - You may want to have a look at http://evgeny-goldin.com/wiki/Gradle-CodeNarc-plugin , which claims to be a more flexible CodeNarc plugin.
        Hide
        levi_h Levi Hoogenberg added a comment -

        Thanks, Peter - this issue was created after a question on the mailing list. I posted a follow-up question on the mailing list as well.

        Show
        levi_h Levi Hoogenberg added a comment - Thanks, Peter - this issue was created after a question on the mailing list. I posted a follow-up question on the mailing list as well.
        Hide
        levi_h Levi Hoogenberg added a comment -

        I merged the approach taken in Evgeny's and Gradle's plugins (into http://code.google.com/p/rivoli/source/browse/gradle/codenarc.gradle - it's somewhat ironic that we haven't configured the number of allowed violations yet) - you may close this issue as "won't fix" (unless someone else is interested in fixing it).

        Show
        levi_h Levi Hoogenberg added a comment - I merged the approach taken in Evgeny's and Gradle's plugins (into http://code.google.com/p/rivoli/source/browse/gradle/codenarc.gradle - it's somewhat ironic that we haven't configured the number of allowed violations yet) - you may close this issue as "won't fix" (unless someone else is interested in fixing it).
        ldaley Luke Daley made changes -
        Field Original Value New Value
        Workflow jira with pivotal tracker [ 14898 ] jira with pivotal tracker (no resolved, only closed) [ 16969 ]
        ldaley Luke Daley made changes -
        Workflow jira with pivotal tracker (no resolved, only closed) [ 16969 ] Copy of jira with pivotal tracker (no closed, only resolved) [ 19575 ]
        Hide
        dstine Dan Stine added a comment -

        I have submitted a pull request that addresses this issue.

        https://github.com/gradle/gradle/pull/144

        Show
        dstine Dan Stine added a comment - I have submitted a pull request that addresses this issue. https://github.com/gradle/gradle/pull/144
        breskeby René Gröschke made changes -
        Assignee René Gröschke [ breskeby ]
        breskeby René Gröschke made changes -
        Status Open [ 1 ] In Progress [ 3 ]
        breskeby René Gröschke made changes -
        Status In Progress [ 3 ] Open [ 1 ]
        Hide
        breskeby René Gröschke added a comment -

        solved via pull-request. thanks Dan!

        Show
        breskeby René Gröschke added a comment - solved via pull-request. thanks Dan!
        breskeby René Gröschke made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        adammurdoch Adam Murdoch made changes -
        Fix Version/s 1.7-rc-1 [ 10675 ]

          People

          • Assignee:
            breskeby René Gröschke
            Reporter:
            levi_h Levi Hoogenberg
          • Votes:
            1 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development