Cleaning should be more robust on Windows

Details

  • Type: Improvement Improvement
  • Status: Resolved Resolved
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 1.1-rc-1

Description

I'm seeing this on windows when the indexer is on.

It manifests as java.io.IOException: Unable to delete file/directory, and then a subsequent clean will succeed.

We could cater for this by noting that a particular operation failed, and then retrying it again at the end or after some time.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Szczepan Faber added a comment -

If we develop this feature they will probably have to remember all undeletable dirs. So I'd vote to also improve the error message to include the list of all dirs that the build could not delete at clean. This would be very useful in windows.

Show
Szczepan Faber added a comment - If we develop this feature they will probably have to remember all undeletable dirs. So I'd vote to also improve the error message to include the list of all dirs that the build could not delete at clean. This would be very useful in windows.
Pivotal Tracker Integration made changes -
Field Original Value New Value
Status Open [ 1 ] In Progress [ 3 ]
Hide
Create a new review for changeset 5a5b860b48642d00bb736ce9fbaf96dc40563fb5
Luke Daley <ld@ldaley.com> submitted changeset 5a5b860b48642d00bb736ce9fbaf96dc40563fb5 to pull-request-138 in Gradle (1 file) - 21/Jul/12 5:15 AM

GRADLE-2244 - try to make cleaning more robust on Windows.
This is based on code in Ant that deals with deleting files. It eludes to there being a bug in Windows JDKs that is “fixable” by running a GC when a file files to delete and then trying again. Some googling finds similar information, but I haven't been able to find a definitive reference.

There is no added coverage for this as I'm unsure how to write a reliable test at this time. It can be manually tested though.

Show
Create a new review for changeset 5a5b860b48642d00bb736ce9fbaf96dc40563fb5
Luke Daley <ld@ldaley.com> submitted changeset 5a5b860b48642d00bb736ce9fbaf96dc40563fb5 to pull-request-138 in Gradle (1 file) - 21/Jul/12 5:15 AM
Hide
Permalink
Luke Daley added a comment -

Szczepan,

I'm inclined not to include this. The reason is that it actually makes the logic non trivially more complex, and would only really help in the situation where someone has asked to delete multiple roots which is rare. Typically the delete is just operating on the “build dir”.

Show
Luke Daley added a comment - Szczepan, I'm inclined not to include this. The reason is that it actually makes the logic non trivially more complex, and would only really help in the situation where someone has asked to delete multiple roots which is rare. Typically the delete is just operating on the “build dir”.
Luke Daley made changes -
Fix Version/s 1.1-rc-1 [ 10360 ]
Adam Murdoch made changes -
Resolution Fixed [ 1 ]
Status In Progress [ 3 ] Resolved [ 5 ]
Luke Daley made changes -
Summary Cleaning should be more robust (e.g. to deal with OS indexers that quickly lock/unlock files) Cleaning should be more robust on Windows
Hide
Permalink
Luke Daley added a comment -

After some research, it appears that this may be due to a bug in the Windows JDKs (incl IBM). Ant uses a strategy of forcing a GC after a failed delete and then waiting a small amount of time. Given that this appears to be a successful strategy for Ant, we have adopted it.

Show
Luke Daley added a comment - After some research, it appears that this may be due to a bug in the Windows JDKs (incl IBM). Ant uses a strategy of forcing a GC after a failed delete and then waiting a small amount of time. Given that this appears to be a successful strategy for Ant, we have adopted it.
Luke Daley made changes -
Assignee Luke Daley [ ldaley ]
Pivotal Tracker Integration made changes -
Status Resolved [ 5 ] Closed [ 6 ]
Luke Daley made changes -
Workflow jira with pivotal tracker [ 15595 ] jira with pivotal tracker (no resolved, only closed) [ 17668 ]
Luke Daley made changes -
Status Closed [ 6 ] Resolved [ 5 ]
Workflow jira with pivotal tracker (no resolved, only closed) [ 17668 ] Copy of jira with pivotal tracker (no closed, only resolved) [ 20303 ]
Unable to get TeamCity builds: No active plugin license is found! Please visit http://stiltsoft.com/teamcity for details

People

  • Assignee:
    Luke Daley
    Reporter:
    Luke Daley
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: