Cannot use EclipseProject.getGradleProject() or acquire GradleProject model for pre-m5 Gradle versions

Details

Type: Bug
Status: Resolved
Resolution: Fixed
Affects Version/s: None
Fix Version/s: 1.0-rc-1

Description

EclipseProject.getTasks() is now deprecated, but the replacement EclipseProject.getGradleProject().getTasks() does not work for pre-m5 releases.

Activity

Ascending order - Click to sort in descending order

Szczepan Faber made changes - 13/Mar/12 10:24 AM

Field	Original Value	New Value
Fix Version/s	1.0-milestone-9 [ 10161 ]
Fix Version/s		1.0-rc-1 [ 10062 ]

Hide

Permalink

Szczepan Faber added a comment - 13/Mar/12 10:24 AM

I'm wondering whether we should care about it... m4 was broken and m3 is veeery old.

Show

Szczepan Faber added a comment - 13/Mar/12 10:24 AM I'm wondering whether we should care about it... m4 was broken and m3 is veeery old.

Hide

Permalink

Kris De Volder added a comment - 19/Mar/12 5:29 PM

Yes. There are still projects out there that are on M3. (E.g. spring-security).
Perhaps these people can be expected to move on "soon". But the truth is that if there builds are working fine, they may be reluctant to tackle the upgrade.

This problem is quite serious to me now that the method has been removed in M9, I either have these two options:
1) people with M3 projects can no longer run/view any tasks (which also breaks import if those project's import relies on executing some tasks).
2) continue to stick with tooling API M7

So to me that is a real blocker for moving to Tooling API M9.

For now I'm going with (2). But if EclipseProject.getEclipseTasks is put back in some snapshot build. I may consider basing the next STS-Gradle support of off that Gradle snapshot build instead.

Kris

Show

Kris De Volder added a comment - 19/Mar/12 5:29 PM Yes. There are still projects out there that are on M3. (E.g. spring-security). Perhaps these people can be expected to move on "soon". But the truth is that if there builds are working fine, they may be reluctant to tackle the upgrade. This problem is quite serious to me now that the method has been removed in M9, I either have these two options: 1) people with M3 projects can no longer run/view any tasks (which also breaks import if those project's import relies on executing some tasks). 2) continue to stick with tooling API M7 So to me that is a real blocker for moving to Tooling API M9. For now I'm going with (2). But if EclipseProject.getEclipseTasks is put back in some snapshot build. I may consider basing the next STS-Gradle support of off that Gradle snapshot build instead. Kris

Hide

Permalink

Kris De Volder added a comment - 20/Mar/12 1:37 PM

Please raise this issue to 'Critical' or 'Blocker'. This is a blocker. The tooling M9 API is unusable for me. I.e. I can not consider upgrading STS to use M9 until the EclipseProject.getTasks method is put back in.

Show

Kris De Volder added a comment - 20/Mar/12 1:37 PM Please raise this issue to 'Critical' or 'Blocker'. This is a blocker. The tooling M9 API is unusable for me. I.e. I can not consider upgrading STS to use M9 until the EclipseProject.getTasks method is put back in.

Hide

Permalink

Adam Murdoch added a comment - 20/Mar/12 5:05 PM

@Kris, this should be fixed soon.

Show

Adam Murdoch added a comment - 20/Mar/12 5:05 PM @Kris, this should be fixed soon.

Hide

Permalink

Kris De Volder added a comment - 23/Mar/12 4:02 PM

This isues blocks: https://issuetracker.springsource.com/browse/STS-2509

Show

Kris De Volder added a comment - 23/Mar/12 4:02 PM This isues blocks: https://issuetracker.springsource.com/browse/STS-2509

Hide

Permalink

Kris De Volder added a comment - 23/Mar/12 4:03 PM

Also blocking: https://issuetracker.springsource.com/browse/STS-2276

Show

Kris De Volder added a comment - 23/Mar/12 4:03 PM Also blocking: https://issuetracker.springsource.com/browse/STS-2276

Hide

Permalink

Kris De Volder added a comment - 23/Mar/12 4:05 PM

Also blocking: https://issuetracker.springsource.com/browse/STS-2503

Show

Kris De Volder added a comment - 23/Mar/12 4:05 PM Also blocking: https://issuetracker.springsource.com/browse/STS-2503

Hide

Permalink

Kris De Volder added a comment - 23/Mar/12 4:07 PM

Also blocking: https://issuetracker.springsource.com/browse/STS-2213

Show

Kris De Volder added a comment - 23/Mar/12 4:07 PM Also blocking: https://issuetracker.springsource.com/browse/STS-2213

Hide

Permalink

Kris De Volder added a comment - 23/Mar/12 4:08 PM

And this one too: https://issuetracker.springsource.com/browse/STS-2456

Show

Kris De Volder added a comment - 23/Mar/12 4:08 PM And this one too: https://issuetracker.springsource.com/browse/STS-2456

Pivotal Tracker Integration made changes - 26/Mar/12 2:11 PM

Status

Open [ 1 ]

In Progress [ 3 ]

Hide

Create a new review for changeset 9a8dc99cf9cc86b8cad07d9d043366683682940e

Szczepan Faber <szczepiq@gmail.com> submitted changeset 9a8dc99cf9cc86b8cad07d9d043366683682940e to pull-request-138 in Gradle (5 files) - 27/Mar/12 12:02 AM

~~GRADLE-1875~~ GradleProject model is available for the gradle versions pre M5. Details: -consumer asks for the EclipseProject behind the hood and converts the model to GradleProject -added a tiny tweak to the ProtocolToModelAdapter - when the instance already is of the required type don't adapt anything, just return it. This way the hierarchy is more consistent as we already do similar checks in the object tree. It's also easier to test stuff. -Pending problem: getting the GradleProject for <M5 versions incurrs resolution of the dependencies.

Show

Create a new review for changeset 9a8dc99cf9cc86b8cad07d9d043366683682940e

Szczepan Faber <szczepiq@gmail.com> submitted changeset 9a8dc99cf9cc86b8cad07d9d043366683682940e to pull-request-138 in Gradle (5 files) - 27/Mar/12 12:02 AM

Szczepan Faber made changes - 27/Mar/12 1:44 AM

Assignee

Szczepan Faber [ szczepiq ]

Hide

Create a new review for changeset 9463cb504e3ad6af56c08dca6b6478f2768afab8

Szczepan Faber <szczepiq@gmail.com> submitted changeset 9463cb504e3ad6af56c08dca6b6478f2768afab8 to pull-request-138 in Gradle (15 files) - 27/Mar/12 3:50 AM

~~GRADLE-1875~~ It is possible to ask eclipseProject.getGradleProject() even for target gradle versions <M5.

Show

Create a new review for changeset 9463cb504e3ad6af56c08dca6b6478f2768afab8

Szczepan Faber <szczepiq@gmail.com> submitted changeset 9463cb504e3ad6af56c08dca6b6478f2768afab8 to pull-request-138 in Gradle (15 files) - 27/Mar/12 3:50 AM

Hide

Permalink

Szczepan Faber added a comment - 27/Mar/12 10:43 AM

It's fixed now. You can do EclipseProject.getGradleProject().getTasks() also from M3+ target gradle version.

Show

Szczepan Faber added a comment - 27/Mar/12 10:43 AM It's fixed now. You can do EclipseProject.getGradleProject().getTasks() also from M3+ target gradle version.

Pivotal Tracker Integration made changes - 27/Mar/12 10:43 AM

Resolution		Fixed [ 1 ]
Status	In Progress [ 3 ]	Resolved [ 5 ]

Hide

Permalink

Kris De Volder added a comment - 27/Mar/12 11:14 AM

Excellent! Thanks for that.
Do you recommend a particular Gradle snapshot build for me to use, or should I just pick whatever is the latest at the moment?

Kris

Show

Kris De Volder added a comment - 27/Mar/12 11:14 AM Excellent! Thanks for that. Do you recommend a particular Gradle snapshot build for me to use, or should I just pick whatever is the latest at the moment? Kris

Hide

Permalink

Szczepan Faber added a comment - 27/Mar/12 11:33 AM

Let me kick off a nightly build and get back once it's ready

Show

Szczepan Faber added a comment - 27/Mar/12 11:33 AM Let me kick off a nightly build and get back once it's ready

Hide

Permalink

Szczepan Faber added a comment - 27/Mar/12 1:34 PM

Can you try nightly: http://gradle.org/nightly ?

Show

Szczepan Faber added a comment - 27/Mar/12 1:34 PM Can you try nightly: http://gradle.org/nightly ?

Hide

Permalink

Szczepan Faber added a comment - 27/Mar/12 1:34 PM

Can you try nightly: http://gradle.org/nightly ?

Show

Szczepan Faber added a comment - 27/Mar/12 1:34 PM Can you try nightly: http://gradle.org/nightly ?

Szczepan Faber made changes - 02/Apr/12 6:41 AM

Summary

Cannot use EclipseProject.getGradleProject() for pre-m5 Gradle versions

Cannot use EclipseProject.getGradleProject() or acquire GradleProject model for pre-m5 Gradle versions

Hide

Permalink

Kris De Volder added a comment - 02/Apr/12 10:43 AM

FYI: I've succesfully updated STS Gradle tools to use an RC1 buildsnapshot of the tooling API. All of my regression tests are green. Using EclipseProject.getGradleProject().getTasks() instead of the deprecated method it replaces.

Show

Kris De Volder added a comment - 02/Apr/12 10:43 AM FYI: I've succesfully updated STS Gradle tools to use an RC1 buildsnapshot of the tooling API. All of my regression tests are green. Using EclipseProject.getGradleProject().getTasks() instead of the deprecated method it replaces.

Hide

Permalink

Szczepan Faber added a comment - 02/Apr/12 10:45 AM

Awesome, thanks for feedback.

Show

Szczepan Faber added a comment - 02/Apr/12 10:45 AM Awesome, thanks for feedback.

Pivotal Tracker Integration made changes - 02/Apr/12 3:09 PM

Status

Resolved [ 5 ]

Closed [ 6 ]

Luke Daley made changes - 03/Jan/13 5:09 AM

Workflow

jira with pivotal tracker [ 15031 ]

jira with pivotal tracker (no resolved, only closed) [ 18476 ]

Luke Daley made changes - 04/Jan/13 5:10 AM

Status	Closed [ 6 ]	Resolved [ 5 ]
Workflow	jira with pivotal tracker (no resolved, only closed) [ 18476 ]	Copy of jira with pivotal tracker (no closed, only resolved) [ 21081 ]

Unable to get TeamCity builds: No active plugin license is found! Please visit http://stiltsoft.com/teamcity for details

People

Assignee:

Szczepan Faber

Reporter:

Adam Murdoch

Vote (1)

Watch (2)

Dates

Created:

27/Oct/11 8:01 PM

Updated:

04/Jan/13 5:10 AM

Resolved:

27/Mar/12 10:43 AM