Gradle
  1. Gradle
  2. GRADLE-1766

A dependecy on sourceset.classes breaks GradleDependencies classpath container in Eclipse/STS

    Details

    • Type: Bug Bug
    • Status: Open
    • Resolution: Unresolved
    • Affects Version/s: 1.0-milestone-3
    • Fix Version/s: None

      Description

      Problem manifests itself in this project http://static.springsource.org/spring-security/site/source.html

      When this project is imported into STS Gradle tooling, it produces an invalid classpath for some of the subprojects.
      The error is as follows:

      msg :The container 'Gradle Dependencies' references non existing library '.../spring-security/core/build/classes/test' project: spring-security-web

      This message seems to be caused by the following lines in the projects buid file:

      dependencies {
          ...
          testCompile project(':spring-security-core').sourceSets.test.classes,
                      ...
      }
      

      Workaround, replace the above with

      dependencies

      { ... testCompile project(':spring-security-core'), ... }

        Issue Links

          Activity

          Hide
          Kris De Volder added a comment -

          I can see two ways forward towards fixing this problem. The easiest is probably to aproximate dependencies like these as dependencies on the project that contains the respective source set.

          Another possiblity is that Gradle tooling api provide information on output folders associated with source folders (currently no such information is provided, so I'm setting all output folder to the Eclipse default).

          Then ensure that sourceSet.classes returns the same output folder as was associated with the sourcefolder.

          I'm not so sure how well this will work in Eclipse, I don't think it is generally a good idea to have one project depend on binary class folder in another project. This tends to lead to problem with build mechanics/ordering and trouble associating source code with the class files.

          So I think remapping it as a project dependency is probably best.

          Show
          Kris De Volder added a comment - I can see two ways forward towards fixing this problem. The easiest is probably to aproximate dependencies like these as dependencies on the project that contains the respective source set. Another possiblity is that Gradle tooling api provide information on output folders associated with source folders (currently no such information is provided, so I'm setting all output folder to the Eclipse default). Then ensure that sourceSet.classes returns the same output folder as was associated with the sourcefolder. I'm not so sure how well this will work in Eclipse, I don't think it is generally a good idea to have one project depend on binary class folder in another project. This tends to lead to problem with build mechanics/ordering and trouble associating source code with the class files. So I think remapping it as a project dependency is probably best.
          Hide
          Kris De Volder added a comment -

          Classified as minor issue because there is a relatively easy workaround.

          Show
          Kris De Volder added a comment - Classified as minor issue because there is a relatively easy workaround.
          Hide
          Rob Winch added a comment - - edited

          I'm not sure I consider this minor because, unless I am missing something, the workaround will break the actual gradle build. I believe this issue may be related to GRADLE-1116

          Show
          Rob Winch added a comment - - edited I'm not sure I consider this minor because, unless I am missing something, the workaround will break the actual gradle build. I believe this issue may be related to GRADLE-1116
          Hide
          Adam Murdoch added a comment -

          I think we should map this as a project dependency.

          Show
          Adam Murdoch added a comment - I think we should map this as a project dependency.

            People

            • Assignee:
              Unassigned
              Reporter:
              Kris De Volder
            • Votes:
              4 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:

                Development